aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26102: Dropping assert on empty desired instances set.
Date Mon, 29 Sep 2014 23:32:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 11:32 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

CR comments.


Bugs: AURORA-756
    https://issues.apache.org/jira/browse/AURORA-756


Repository: aurora


Description
-------

Dropping assert on empty desired instances set.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664

  src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924

  src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5

  src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427

  src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 62d08ad141f271ffb2627df138a5ef445f8f88d7

  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7

  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4934cbbc55e14756c7719be1bd7bb8dc1f31592f


Diff: https://reviews.apache.org/r/26102/diff/


Testing
-------

gradle -Pq build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message