aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26102: Dropping assert on empty desired instances set.
Date Mon, 29 Sep 2014 23:31:55 GMT


> On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java, line 197
> > <https://reviews.apache.org/r/26102/diff/3/?file=708816#file708816line197>
> >
> >     Adding optional here seems circuitous.  Why not avoid calling `asMap` if `config`
is null?
> >     
> >         instructions.isSetDesiredState() ? asMap(..) : ImmutableMap.of()
> >     
> >     This matches the approach you used in `UpdateFactory`.

I guess if it does not have to be public I agree. Changed it to private and dropped Optional<>.


> On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java, line
57
> > <https://reviews.apache.org/r/26102/diff/3/?file=708815#file708815line57>
> >
> >     Comment lacks context.  This should suffice:
> >     
> >         // Desired state is assumed to be non-null when AddTask is used.

Done.


> On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java, line
377
> > <https://reviews.apache.org/r/26102/diff/3/?file=708818#file708818line377>
> >
> >     s/DoesNotThrow//

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54911
-----------------------------------------------------------


On Sept. 29, 2014, 10:57 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 10:57 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-756
>     https://issues.apache.org/jira/browse/AURORA-756
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Dropping assert on empty desired instances set.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924

>   src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5

>   src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427

>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
83630a350f488d002a653dd31c170a1e918e49b7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314

> 
> Diff: https://reviews.apache.org/r/26102/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message