aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26123: Fail the build on lack of test coverage.
Date Mon, 29 Sep 2014 20:06:20 GMT


> On Sept. 28, 2014, 4:05 a.m., Joshua Cohen wrote:
> > build.gradle, line 571
> > <https://reviews.apache.org/r/26123/diff/1/?file=707768#file707768line571>
> >
> >     This seems like a potentially harsh penalty for good behavior if someone has
to go from 0 to $MIN_COVERAGE in one go...
> >     
> >     I can imagine it encouraging the opposite of the desired behavior for someone
adding new code to a legacy class but not adding code coverage because it means writing tests
for the entire class as part of their change.

I think you might have a different idea of how this diff behaves (and perhaps the message
should be updated to reflect as much - please advise).

This assertion will trip if there is _any_ test coverage added to one of these legacy classes.
 When you encounter this message, you should pat yourself on the back and remove the class
from the legacy list.  It's a provision to prevent the list itself from becoming stale.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26123/#review54772
-----------------------------------------------------------


On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26123/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 11:25 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This will fail the build if:
> - global line or branch coverage is below a threshold
> - a class has no test coverage
> - a class flagged as known to have no coverage gains coverage
> 
> Hopefully we can all contribute to whittle the legacy non-covered list down to zero.
> 
> 
> Diffs
> -----
> 
>   build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 
> 
> Diff: https://reviews.apache.org/r/26123/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message