aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 26095: Fix instance summary visualisation.
Date Mon, 29 Sep 2014 17:36:52 GMT


> On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 440
> > <https://reviews.apache.org/r/26095/diff/1/?file=706256#file706256line440>
> >
> >     As far as I can see, allInstances is only used here to get the length, can we
just make this:
> >     
> >         var totalInstancesToBeUpdated = Object.keys(updateUtil.getAllInstanceIds(details.update).allIds).length
> 
> David McLaughlin wrote:
>     Right. Did it this way because that one-liner exceeds 100 characters.

I know in java we'd prefer to just inline and do a continuation indent rather than extract
a separate var. Does that seem reasonable for js as well?


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26095/#review54716
-----------------------------------------------------------


On Sept. 29, 2014, 4:11 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26095/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 4:11 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-755
>     https://issues.apache.org/jira/browse/AURORA-755
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> See JIRA ticket.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 92c78c28020d36b978f1a098202174015ace1316

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8ed95737ea69112d4ee04b687281d06a21d6abf6

> 
> Diff: https://reviews.apache.org/r/26095/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Growing a job shows correct instance ids
>   https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png
> Instances removed are identified when shrinking job from 5 instances to 1
>   https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message