aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26102: Dropping assert on empty desired instances set.
Date Fri, 26 Sep 2014 23:35:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54751
-----------------------------------------------------------



src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
<https://reviews.apache.org/r/26102/#comment95041>

    IIUC you could also trip this with an update that reduces the instance count in a job.
 Can you add a test case for that?


- Bill Farner


On Sept. 26, 2014, 9:34 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26102/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 9:34 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-756
>     https://issues.apache.org/jira/browse/AURORA-756
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Dropping assert on empty desired instances set.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314

> 
> Diff: https://reviews.apache.org/r/26102/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message