aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 25481: Adding JobUpdateRequest validation.
Date Fri, 26 Sep 2014 18:31:41 GMT


> On Sept. 26, 2014, 6:18 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java, line 80
> > <https://reviews.apache.org/r/25481/diff/2/?file=705767#file705767line80>
> >
> >     This code should still be defensive - it cares about these values.  Please revert.

Feels kind of redundant but I am OK reverting all but the last desiredState.instances validation
(AURORA-756).


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25481/#review54705
-----------------------------------------------------------


On Sept. 25, 2014, 10:02 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25481/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 10:02 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding JobUpdateRequest validation.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2

>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
a894a3aca18d3101543c3520ab4d547d63cd6d61 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314

> 
> Diff: https://reviews.apache.org/r/25481/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message