aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 26012: Use BufferedOutputStream for deflater
Date Thu, 25 Sep 2014 21:24:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26012/
-----------------------------------------------------------

(Updated Sept. 25, 2014, 2:24 p.m.)


Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner.


Changes
-------

Add explanatory comment.


Repository: aurora


Description
-------

Use BufferedOutputStream for deflater


Diffs (updated)
-----

  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 45cf7ecf52582ba3fd7bbc8b4a981e396793da4b


Diff: https://reviews.apache.org/r/26012/diff/


Testing
-------

./gradlew build

Also put together a microbenchmark with a scheduler backup from my production environment
- using a BufferedOutputStream gets a 4sec speedup with no reduction in compression ratio.
¯_(?)_/¯

# Deflater.BEST_SPEED, No buffer
deflate: 11745ms
total:12734ms
compression ratio: 647270930/121616834 = 532.22%

# Deflater.BEST_SPEED, buf = 512KiB
deflate: 11015ms
total:12001ms
compression ratio: 647270930/121616834 = 532.22%

# Deflater.BEST_SPEED, BufferedOutputStream
deflate: 6885ms
total:7694ms
compression ratio: 647270930/121616834 = 532.22%

# Deflater.BEST_SPEED, BufferedOutputStream at 512KiB
deflate: 6752ms
total:7585ms
compression ratio: 647270930/121616834 = 532.22%

# Deflater.DEFAULT_COMPRESSION
deflate: 16664ms
total:17219ms
compression ratio: 647270930/92690409 = 698.31%

# Deflater.DEFAULT_COMPRESSION, buf size = 512KiB
deflate: 16516ms
total:17103ms
compression ratio: 647270930/92690409 = 698.31%

# Deflater.DEFAULT_COMPRESSION, BufferedOutputStream
deflate: 12241ms
total:12788ms
compression ratio: 647270930/92690409 = 698.31%

# Deflater.DEFAULT_COMPRESSION, BufferedOutputStream at 512KiB
deflate: 11548ms
total:12108ms
compression ratio: 647270930/92690409 = 698.31%


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message