aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 25970: Adding support for retryable storage errors.
Date Wed, 24 Sep 2014 17:06:57 GMT


> On Sept. 24, 2014, 4:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java,
line 82
> > <https://reviews.apache.org/r/25970/diff/1/?file=703526#file703526line82>
> >
> >     Is there a downside if we always throw the more specific StorageException, rather
than in these few cases?
> 
> Maxim Khutornenko wrote:
>     Not sure I understand. Are you suggesting altering a StorageException with something
like isRetryable flag instead? Otherwise, we would not be able to differentiate between truly
retryable cases like these ones from something like failed SQL insert/select.

Nope i'm saying why should this class have retryIfNotInReadyState() throwing RetryableStorageException
_and_ checkInState() throwing StorageException?

i.e. can this diff just change checkInState to throw RetryableStorageException?


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54424
-----------------------------------------------------------


On Sept. 24, 2014, 12:29 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 12:29 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-187
>     https://issues.apache.org/jira/browse/AURORA-187
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in
scheduler_client. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f

>   src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e

>   src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
21e8a8ba5c47f549133ea339899bf0e5097ccbb9 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282

> 
> Diff: https://reviews.apache.org/r/25970/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message