aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 25953: Allow optional initial and desired states.
Date Tue, 23 Sep 2014 21:10:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/
-----------------------------------------------------------

(Updated Sept. 23, 2014, 9:10 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

CR comments.


Bugs: AURORA-741
    https://issues.apache.org/jira/browse/AURORA-741


Repository: aurora


Description
-------

Added safety checks around initial/desired state presence and converted to left outer joins.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 361d3b8c0d59a0dad6b00c8a4b78ec8284383586

  src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 80535432c2c45eb2f3eb3bea4a797a99ea4fc2c9

  src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java aa7feb916f879f60d46ebaf53e47ba30d861c7fa


Diff: https://reviews.apache.org/r/25953/diff/


Testing
-------

gradle -Pq build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message