aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 25857: Disable updater by default in prod.
Date Sat, 20 Sep 2014 02:14:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25857/#review54071
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/25857/#comment94020>

    How about `enable_beta_updater`



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/25857/#comment94021>

    "Enable the async updater. Use at your own risk, this feature is not yet complete."



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/25857/#comment94019>

    While you're here, can you remove this constructor overload?  It's unused.



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/25857/#comment94018>

    How about:
    
        return addMessage(
            emptyResponse(),
            INVALID_REQUEST,
           "Server-side updates are disabled on this cluster.");



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/25857/#comment94022>

    I see why you went this route, but it's a precedent i'd rather not set.  How about a guice-bound
`@EnableUpdater Boolean`.  Then, create a new test class that does nothing but create necessary
mocks to construct an instance of SchedulerThriftInterface and test the flag.


- Bill Farner


On Sept. 19, 2014, 11:10 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25857/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 11:10 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-732
>     https://issues.apache.org/jira/browse/AURORA-732
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added command line arg to control startJobUpdate.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 83ac034cff009530e5e16c0613b9d085f3b908d8

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
336cada625b85618486660fc24f3e83a312609f8 
> 
> Diff: https://reviews.apache.org/r/25857/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message