aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Review Request 25840: Perform a deep copy of mutable thrift objects in generated FROM_BUILDER functions.
Date Fri, 19 Sep 2014 18:03:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25840/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-729
    https://issues.apache.org/jira/browse/AURORA-729


Repository: aurora


Description
-------

At one point, the constructor _did_ detach objects, but this hole remained when buildNoCopy
was introduced.


Diffs
-----

  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 95fbd8950350786582dcd9dbfbe8b56f9f866700

  src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/25840/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message