aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 25791: Save instance update events when updating a job.
Date Thu, 18 Sep 2014 20:50:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25791/#review53870
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Sept. 18, 2014, 8:48 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25791/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 8:48 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-613
>     https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> A follow-up change will scope the updaters to actionable instance changes, which will
remove the redundant actions being saved (see TODOs).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java 0442191d3a84e1a6bbeb2a79fda78ef077ee0d04

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 34f12a9ff0f265561e349800f972a10db41a9fec

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 33bf7c7e6eeb538cf14fb3b9e58ae058390f7e05

>   src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java d9e59b6c1270f70235c4d0c38a8df7ce70499768

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 0e15a79ae6dc877dfa6ba492efafdf1f89f7d40f

> 
> Diff: https://reviews.apache.org/r/25791/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message