aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 25760: Performance improvements and instrumentation for snapshot
Date Thu, 18 Sep 2014 00:56:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25760/#review53778
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java
<https://reviews.apache.org/r/25760/#comment93582>

    Static import?



src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java
<https://reviews.apache.org/r/25760/#comment93581>

    Technically, the outBytes may already be disposed at this point. Move return inside of
outer try()?



src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java
<https://reviews.apache.org/r/25760/#comment93583>

    Line break after '=' instead?



src/test/java/org/apache/aurora/codec/ThriftBinaryCodecTest.java
<https://reviews.apache.org/r/25760/#comment93585>

    Now you have to add jsmith to reviewers :)


- Maxim Khutornenko


On Sept. 18, 2014, 12:20 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25760/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 12:20 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-722
>     https://issues.apache.org/jira/browse/AURORA-722
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> * Deflate snapshots using stream API
> * Make LogManager non-final
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java da4f0e5520f85782bbc246752cde29bd279be466

>   src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 1eca768a7daf6defd4bb35a5c46e9c0eab370d92

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 0b59043cf5f01c99d09168d7669f51b686d2e930

>   src/test/java/org/apache/aurora/codec/ThriftBinaryCodecTest.java 7aaab1e7debbfed65ac7c15154ec73fc9f2114af

> 
> Diff: https://reviews.apache.org/r/25760/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> The StreamManager @Timed annotations don't work yet since guice isn't used to instantiate
it. Ideally we'd use AssistedInject here, but that's a slightly larger change.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message