aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <>
Subject Review Request 25721: Asynchronous JS for Scheduler UI
Date Wed, 17 Sep 2014 00:48:40 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.

Bugs: AURORA-700

Repository: aurora


Asynchronous JS for Scheduler UI.

I have tried to change the minimum amount of JavaScript to keep this review small, even though
doing this made me really want to tear everything up and start again :-)

I attached two screenshots to show the sync vs async behaviour in the browser - note that
the async version is 2x the latency of the first. This is because the getJobSummary requests
is 10KB compared to <1KB in the sync version. The point is how work is done in parallel.


  src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 14dce65158eab83906c68f9afabf49e39283287d

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 0884cc8f0504a953ef694dae0e6b05ba6e2bff61

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js c80146aa3829e3c3102645a1864dbeaf5e2e56bc



./gradlew jsHint

I did manual testing to verify I didn't accidentally introduce any regressions. I have around
80% confidence there are no regressions here, mainly because I wasted an hour on totally unintuitive
behaviour from SmartTable. So I'm going to do a bunch more testing, which will involve mocks
for updates and crons.

File Attachments

Before: Synchronous, serial evaluation of network requests.
AFTER: Asynchronous, parallel network requests.


David McLaughlin

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message