aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 25543: Update to pants 0.0.23.
Date Mon, 15 Sep 2014 12:50:15 GMT


> On Sept. 12, 2014, 6:54 p.m., Brian Wickman wrote:
> > I noticed you just commented out some of the timeout= keywords -- do you plan to
remove those or just leave them as annotations?

Leave them as annotations. I'm not really clear on why the timeout was removed, but the fact
that we believe that these tests should be considered as failed if they take longer than that
timeout period seems like something worth preserving.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25543/#review53239
-----------------------------------------------------------


On Sept. 11, 2014, 12:13 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25543/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 12:13 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: aurora-695
>     https://issues.apache.org/jira/browse/aurora-695
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Update build files for the new syntax, which no longer requires
>   'pants(...)' around target names.
> - Remove no-longer-supported "timeout" from python_tests.
> 
> 
> Diffs
> -----
> 
>   pants 4f9c351888afa1a779415730240093c3dee25dfb 
>   src/main/python/apache/aurora/admin/BUILD 7a100d1a4a74aae034082f34db051c9cc31f8540

>   src/main/python/apache/aurora/client/BUILD bf196bf86b36db0d72f8e096260c9a900f74d07c

>   src/main/python/apache/aurora/client/api/BUILD 70ad38e34f14c6d54b71c8f4b2138f085658110e

>   src/main/python/apache/aurora/client/bin/BUILD 43d747956df0611b0880f64df9955d5f5806901c

>   src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32

>   src/main/python/apache/aurora/client/commands/BUILD cc16923909a7b26b0f3ac0b47bb37dafdbbf502e

>   src/main/python/apache/aurora/client/hooks/BUILD 9471c4cba5175296030747301e246a65a39aa203

>   src/main/python/apache/aurora/common/BUILD b879b15127d6691b35880074fd0ceacd866a61ed

>   src/main/python/apache/aurora/common/auth/BUILD 7e96cb2258711b2e2925d18ad9435fa986e86bca

>   src/main/python/apache/aurora/config/BUILD 4f8fad80114ddabac8b25f70bba00119228ec675

>   src/main/python/apache/aurora/config/schema/BUILD 69d60aebd2a9aa353497406ae578a9997323b07e

>   src/main/python/apache/aurora/executor/BUILD 1ad8f82cdce85cf228c53e088171918e36ed536d

>   src/main/python/apache/aurora/executor/bin/BUILD aeb8aee6f50a0d89714626e933699c0a13b363d9

>   src/main/python/apache/aurora/executor/common/BUILD 335ebc4809096c5f128846cd846d33910a777968

>   src/main/python/apache/thermos/BUILD 0dc035f759dd9949997f0c979b3556a350cf8df7 
>   src/main/python/apache/thermos/bin/BUILD 669f9930a3590184dc0f8b5c15c36168e715eb03 
>   src/main/python/apache/thermos/common/BUILD 6015f9e9a23f71bf6dede1f4698fe63dbb4dcfaa

>   src/main/python/apache/thermos/config/BUILD 0531f92ea569ffe36817b645a17fab7a712e5897

>   src/main/python/apache/thermos/core/BUILD 0d1d339d55ee6a569297614ac734661e5caf7ea4

>   src/main/python/apache/thermos/monitoring/BUILD 79da0d5cef9436d4a3d83075910decfc93e422a6

>   src/main/python/apache/thermos/observer/BUILD 49b844ffc1b1d5911fc28d14294d088c3d0b6e4b

>   src/main/python/apache/thermos/observer/bin/BUILD 044ca66b18282daf17a4198ff369d954e14c9b6d

>   src/main/python/apache/thermos/observer/http/BUILD 901ad9c61e4dd1c61f5fbf4467becb8c881a64ed

>   src/main/python/apache/thermos/testing/BUILD dc328a63788381307576b5a43ecdc704bb764473

>   src/main/thrift/org/apache/aurora/gen/BUILD 947504ec1f9582496952b23e66d7f5f20a168ce7

>   src/test/python/BUILD f01efff2e4982a475221b5739dfe1e8fd1a41d92 
>   src/test/python/apache/aurora/BUILD 6555b984a713ef786aef5688b206ae9d8017c48d 
>   src/test/python/apache/aurora/admin/BUILD 5e170d6c15a95e2511b69e18a255d7364c2e7a4d

>   src/test/python/apache/aurora/client/BUILD 831a72d39b27ca2aca466a389140000bbf40ff94

>   src/test/python/apache/aurora/client/api/BUILD b4f08c6192e6bf6b38665197e98db7235751ae86

>   src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649

>   src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b

>   src/test/python/apache/aurora/client/hooks/BUILD f7856a2d5dc7e5d1edc480f64d5db97d88c71b70

>   src/test/python/apache/aurora/common/BUILD e949ba8859d5567c62623bec9d5ba86a8463fbaa

>   src/test/python/apache/aurora/config/BUILD 37bbd27e13a2a3589faff7285f04e3c44ca57eeb

>   src/test/python/apache/aurora/executor/BUILD 4d43e256ad131223cc1ac36a406d42a979a8a2dd

>   src/test/python/apache/aurora/executor/common/BUILD 7d8934046b56ac2c0c16440cfc571dc370767a14

>   src/test/python/apache/thermos/BUILD cb93a4622e33ef96855b89a7c138f42033368950 
>   src/test/python/apache/thermos/bin/BUILD 4b59f3879298de9664f168150ea9029e013e7913 
>   src/test/python/apache/thermos/common/BUILD 36fa6a69b5e77a645a65c52fef6ec9343bf541bc

>   src/test/python/apache/thermos/config/BUILD 42445ceccba8dfe8296a22a174aca6123bdfdb52

>   src/test/python/apache/thermos/core/BUILD 8f5c626c2e89834dbb4938c3c69ef8c79558e12b

>   src/test/python/apache/thermos/monitoring/BUILD ea4005b52be3185e553f7d23fb29b89f68befa50

> 
> Diff: https://reviews.apache.org/r/25543/diff/
> 
> 
> Testing
> -------
> 
> - Ran all unit tests: several fail, but they also fail under the previous version of
pants.
> - Built all python_binary targets in src/main/python/apache/aurora.
> - Verified that resulting pexes executed correctly.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message