aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 25459: Adding quota check into startJobUpdate.
Date Fri, 12 Sep 2014 23:04:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25459/#review53238
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java
<https://reviews.apache.org/r/25459/#comment92782>

    You mean inclusive?



src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java
<https://reviews.apache.org/r/25459/#comment92793>

    This treats the update as though it is purely additive.  e.g. if i'm updating my job,
i'm charged for 2x that job's resources.
    
    I believe the algorithm we'll need to use is max(before_update, after_update) when determining
the impact of an update.
    
    The trouble here becomes visibility, we need to do some follow-up UI work so users aren't
baffled when they're being charged for a paused update.


- Bill Farner


On Sept. 9, 2014, 12:30 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25459/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 12:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Wiring TaskLimitValidator into the startJobUpdate API.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e

>   src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2

>   src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 8f18617b2052201f87bb1464314c2ee45b279276

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
0d51f7dc367081f72090736e36605bf363f3395e 
> 
> Diff: https://reviews.apache.org/r/25459/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message