aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <>
Subject Re: Review Request 25593: Use a ServletContextListener to configure servlets
Date Fri, 12 Sep 2014 21:43:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 12, 2014, 2:43 p.m.)

Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.


jcohen's feedback

Repository: aurora


This paves the way for ShiroWebModule integration. As an added benefit Guice is now instantiating
our servlets for us (no injector.getInstance calls in our code).

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/http/ 9d8654b4268a13fc9d29d12f8da2c1aa8fda4b2b



./gradlew -Pq build

No new tests added - the existing JerseyServletModuleTests already cover correctness of wiring.


Kevin Sweeney

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message