aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 25593: Use a ServletContextListener to configure servlets
Date Fri, 12 Sep 2014 21:39:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25593/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 2:39 p.m.)


Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.


Changes
-------

+jcohen


Repository: aurora


Description
-------

This paves the way for ShiroWebModule integration. As an added benefit Guice is now instantiating
our servlets for us (no injector.getInstance calls in our code).


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 9d8654b4268a13fc9d29d12f8da2c1aa8fda4b2b


Diff: https://reviews.apache.org/r/25593/diff/


Testing
-------

./gradlew -Pq build

No new tests added - the existing JerseyServletModuleTests already cover correctness of wiring.


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message