aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 25582: Fix error in client "task ssh" command when the job isn't found.
Date Fri, 12 Sep 2014 17:17:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25582/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 1:17 p.m.)


Review request for Aurora, David McLaughlin and Zameer Manji.


Changes
-------

Address review comments.


Bugs: aurora-706
    https://issues.apache.org/jira/browse/aurora-706


Repository: aurora


Description
-------

Fix error in client "task ssh" command when the job isn't found.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/task.py 91175facdc8ccccc9fd59ab66781f86ee8b5940a

  src/main/python/apache/aurora/client/commands/ssh.py 37a90089b72b86c82466f1819e7881a36bb2f214

  src/test/python/apache/aurora/client/cli/test_task_run.py 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b

  src/test/python/apache/aurora/client/commands/test_ssh.py 4070b710b005c91fe08dd7906cd93bf3a8cdba9e


Diff: https://reviews.apache.org/r/25582/diff/


Testing
-------

Added new tests to catch this case;
Ran all client unit tests, all tests pass.


Thanks,

Mark Chu-Carroll


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message