aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 25481: Adding JobUpdateRequest validation.
Date Thu, 11 Sep 2014 19:06:54 GMT


> On Sept. 11, 2014, 5:54 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1371
> > <https://reviews.apache.org/r/25481/diff/1/?file=684118#file684118line1371>
> >
> >     I believe this will not surface nicely to the user, but will instead present
as an internal error (based on LoggingInterceptor, which handles uncaught exceptions).
> 
> Maxim Khutornenko wrote:
>     ERROR type is correctly consumed by the client. Here is an example from vagrant:
>     
>     ```INFO] Response from scheduler: ERROR (message: TaskQuery is missing.)```
> 
> Bill Farner wrote:
>     Right, but shouldn't we be returning `INVALID_REQUEST`?

Good point. Raised https://issues.apache.org/jira/browse/AURORA-701 to validate on the client
instead. These should rather stay ERRORs to catch API-side violations.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25481/#review53061
-----------------------------------------------------------


On Sept. 9, 2014, 7:46 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25481/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 7:46 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding JobUpdateRequest validation.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
0d51f7dc367081f72090736e36605bf363f3395e 
> 
> Diff: https://reviews.apache.org/r/25481/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message