aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 25398: Make the offer hold jitter window configurable.
Date Tue, 09 Sep 2014 16:45:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25398/#review52735
-----------------------------------------------------------



src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java
<https://reviews.apache.org/r/25398/#comment91720>

    Consider using the mock throughout.  You get a little extra bit of verification that it
is not invoked.


- Bill Farner


On Sept. 8, 2014, 9:09 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25398/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 9:09 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-313
>     https://issues.apache.org/jira/browse/AURORA-313
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make the offer hold jitter window configurable.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5a38a1f69ac5dbe68af3bfe175899ddee392880b

>   src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/25398/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message