aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 22457: Improve aurora "job diff" command.
Date Tue, 09 Sep 2014 14:07:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 10:07 a.m.)


Review request for Aurora, Maxim Khutornenko and Brian Wickman.


Changes
-------

Tried modifying the test, to see if that fixes the jenkins build issue.


Bugs: aurora-520
    https://issues.apache.org/jira/browse/aurora-520


Repository: aurora


Description (updated)
-------

Add a new diff method, which uses field-by-field comparison of JSON trees for comparing running
job configurations to potentially updated configs.

- Allow exclusion of semantically irrelevant fields.
- Provide a clearer list of the differences between configs.
- Provide a scripting-friendly alternative JSON syntax for diffs.

The old diff behavior is still available under the "--use-shell-diff" option.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32

  src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf

  src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649

  src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18

  src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22457/diff/


Testing
-------

New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests of the new
functionality.
All tests pass.


Thanks,

Mark Chu-Carroll


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message