aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1
Date Tue, 09 Sep 2014 01:18:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review52662
-----------------------------------------------------------

Ship it!



src/main/python/apache/thermos/core/helper.py
<https://reviews.apache.org/r/25466/#comment91549>

    proc and process seem synonymous, maybe s/proc/child/?



src/main/python/apache/thermos/monitoring/process_collector_psutil.py
<https://reviews.apache.org/r/25466/#comment91550>

    s/proc/child/?


- Kevin Sweeney


On Sept. 8, 2014, 6:14 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25466/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 6:14 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-412
>     https://issues.apache.org/jira/browse/AURORA-412
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade Aurora to psutil 2.1.1
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
>   src/main/python/apache/aurora/executor/executor_vars.py 7665a77ca13bbbc337e345356b70f12357692f3d

>   src/main/python/apache/aurora/executor/gc_executor.py 572c106038602b795a5b6bf08b2b85cf4b6bfec6

>   src/main/python/apache/thermos/core/helper.py 9e4a8fb70df984d175129cb49025b3c222a64679

>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 298459bab01d2c01bef1d69c1150ff2d5737ebbf

>   src/test/python/apache/thermos/core/test_helper.py 58096119e1b412afa36a09da5759c5223a5b5d75

> 
> Diff: https://reviews.apache.org/r/25466/diff/
> 
> 
> Testing
> -------
> 
> Ran tests on OS X but not yet on Linux.  There is adequate coverage.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message