aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 25365: Update slave url to use the thermos port.
Date Fri, 05 Sep 2014 22:14:39 GMT


> On Sept. 5, 2014, 9:41 p.m., Bill Farner wrote:
> > Ship It!

Thanks!  This is now on master
```
commit 277103b
Author: Joshua Cohen <jcohen@twitter.com>
Date:   Fri Sep 5 15:13:33 2014 -0700

    Update slave url to use the thermos port.
    
    Bugs closed: AURORA-644
    
    Reviewed at https://reviews.apache.org/r/25365/
```


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25365/#review52513
-----------------------------------------------------------


On Sept. 4, 2014, 11:09 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25365/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 11:09 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-644
>     https://issues.apache.org/jira/browse/AURORA-644
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update slave url to use the thermos port.
> 
> It was already hardcoded, so I just updated it, but it seems less than ideal. Should
it be a constant or a command line arg?
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/slaves.st defe1c5ececc8d742c78e52b9c43bebebba401ea

> 
> Diff: https://reviews.apache.org/r/25365/diff/
> 
> 
> Testing
> -------
> 
> Ran scheduler, verified updated url.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message