aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 25356: Add a factory to produce OneWayUpdate instances based on job state and update settings.
Date Fri, 05 Sep 2014 19:38:29 GMT


> On Sept. 4, 2014, 10:17 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java,
lines 94-96
> > <https://reviews.apache.org/r/25356/diff/1/?file=679021#file679021line94>
> >
> >     If I am reading it right the update will still proceed in case updateOnlyTheseInstances
specifies an unrecognized range (i.e. not intersecting with the full working set). The InstanceUpdater
appears to handle the optional desiredState as no-op. This is the departure from the current
implementation where a disjoint --shards value fails the update.
> 
> Bill Farner wrote:
>     I think it's best for that to happen higher in the stack.  The thrift interface is
probably the best place for this, to validate a JobUpdateConfiguration when it's received.
> 
> Maxim Khutornenko wrote:
>     I am ok with that but it would require a bit of code duplication to rebuild the working
set as we have to validate updateOnlyTheseInstances against the entire union of old and new
instances.

Aha, that's a very good point.  I'll add it here instead.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25356/#review52363
-----------------------------------------------------------


On Sept. 5, 2014, 5:52 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25356/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-613
>     https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is the bridge between the top-level updater logic and the OneWayJobUpdater - taking
a user request and the direction we've decided to move the job (forward or back), produce
the appropriate OneWayJobUpdater.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 85196af38b6615e5aac7de30a4a601350e935c72

>   src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java aa8b5f2ee81d42db003f27e682f79e94b6625d87

>   src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java dca55ef5612105c9dc8fd57e789fdf1df28ba447

>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java d7baaa679289998a9ea80c0934990a49e5c173d7

>   src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactoryImplTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java e3e50d7d6526e8796dc5cd82b459190b09ceb72f

> 
> Diff: https://reviews.apache.org/r/25356/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message