aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 25357: Adding support for per-job task status metrics.
Date Fri, 05 Sep 2014 00:23:09 GMT


> On Sept. 4, 2014, 11:59 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 168
> > <https://reviews.apache.org/r/25357/diff/1/?file=679026#file679026line168>
> >
> >     To mitigate the risk of OOM in the scheduler's internal TSDB, we should use
untracked stats, similar to what's done in MetricCalculator.java.

Great suggestion, done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52382
-----------------------------------------------------------


On Sept. 4, 2014, 9:42 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 9:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
>     https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 6654c1675ac9f5f7d481e115cea7c224fb212467

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java d02714c846a521ff9ac3e53d991731314e714ae2

> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message