aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24915: Adding initial GC task delay on scheduler restart.
Date Thu, 04 Sep 2014 23:36:11 GMT


> On Sept. 4, 2014, 5:44 p.m., Bill Farner wrote:
> > Per offline discussion, i've realized my memory leak concern is ~moot since we already
have the unbounded HostAttributes store.  I liked your suggestion of augmenting the way this
soft state is used:
> > 
> > - use a Map, no expiry
> > - when receiving an offer, don't kick off a GC task if a map entry is not present,
store a future timestamp after which we should launch a GC task
> 
> Maxim Khutornenko wrote:
>     Thanks. Just to make sure we are on the same page, the bullets above describe exactly
how it's implemented by the current RB.

Hah, i was indeed on a different page - taking another look.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24915/#review52328
-----------------------------------------------------------


On Aug. 20, 2014, 11:35 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24915/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 11:35 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-608
>     https://issues.apache.org/jira/browse/AURORA-608
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding initial GC task delay on scheduler restart.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5a38a1f69ac5dbe68af3bfe175899ddee392880b

>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 65f404915bc60ffe11a7a57d9861ac5b37fa646a

>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 04137072891b2a1f0ad663182629dd469b09324f

> 
> Diff: https://reviews.apache.org/r/24915/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message