aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 25337: Preserve executor HealthCheckerThread name
Date Thu, 04 Sep 2014 17:56:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52332
-----------------------------------------------------------


Discussed offline but it probably makes sense to not do any status checkers subclassed directly
from threading.Thread.  instead, the threads should be attributes on the health checkers and
started when .start() is called.

- Brian Wickman


On Sept. 4, 2014, 10:50 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 10:50 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
> 
> 
> Bugs: AURORA-682
>     https://issues.apache.org/jira/browse/AURORA-682
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Preserve executor HealthCheckerThread name
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b

>   src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676

> 
> Diff: https://reviews.apache.org/r/25337/diff/
> 
> 
> Testing
> -------
> 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor/common:health_checker
> Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/common/BUILD,
health_checker)])
> ==================================================================== test session starts
=====================================================================
> platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 4 items 
> 
> src/test/python/apache/aurora/executor/common/test_health_checker.py ....
> 
> ================================================================== 4 passed in 1.54 seconds
==================================================================
> src.test.python.apache.aurora.executor.common.health_checker                    .....
  SUCCESS
> 
> Tests in vagrant image
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message