aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 25285: Upgrade to latest in jetty 7.x series.
Date Thu, 04 Sep 2014 17:48:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/
-----------------------------------------------------------

(Updated Sept. 4, 2014, 5:48 p.m.)


Review request for Aurora, David McLaughlin and Kevin Sweeney.


Bugs: AURORA-679
    https://issues.apache.org/jira/browse/AURORA-679


Repository: aurora


Description
-------

Long story short: this change adds code, but enables us to remove code in a follow-up.

This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5.
 Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way
to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).

This is also a small step towards insulating ourselves from transitive dependencies pulled
in from twitter commons.

[1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7


Diffs (updated)
-----

  build.gradle 494c54421f716412d20d4591c2d39e24f647c071 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c

  src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/25285/diff/


Testing
-------

./gradlew build -Pq

Ran the scheduler in vagrant, verified index page works, request logging works, and all pages
linked from the index page work.


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message