aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 25309: Fix output formatting error in "job status".
Date Thu, 04 Sep 2014 15:54:06 GMT


> On Sept. 4, 2014, 11:42 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 543
> > <https://reviews.apache.org/r/25309/diff/1-2/?file=675766#file675766line543>
> >
> >     Curious, why not using multiple '\t' instead of spacing?

Looking at the output with standard terminal tab settings, it was ugly. The use of multiple
tabs just ate up too much horizontal space.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52308
-----------------------------------------------------------


On Sept. 4, 2014, 9:24 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25309/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 9:24 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-672
>     https://issues.apache.org/jira/browse/aurora-672
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix output formatting error in "job status".
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py ebc22aaa5a8aed311897b3ce9632b6f7175b6080

>   src/test/python/apache/aurora/client/cli/test_status.py 311fac02af32e0ed687489a2352164effb4dba96

> 
> Diff: https://reviews.apache.org/r/25309/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests; added new test cases.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message