aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 25208: Increment Mesos version to 0.20.0
Date Tue, 02 Sep 2014 18:08:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/#review52049
-----------------------------------------------------------


the test coverage is a great improvement.  thanks joe!

what's the status of mesos.native + the e2e test?  abi incompatible with our vagrant image?


src/main/python/apache/aurora/executor/thermos_task_runner.py
<https://reviews.apache.org/r/25208/#comment90784>

    should these be
    
    mesos_pb2.TASK_LOST
    mesos_pb2.TASK_KILLED
    
    ...etc?


- Brian Wickman


On Aug. 30, 2014, 6:02 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25208/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 6:02 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.
> 
> 
> Bugs: AURORA-674
>     https://issues.apache.org/jira/browse/AURORA-674
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> There's an API change when moving the python executor to 0.20.0, which should deserve
extra scrutiny. 
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
>   build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
>   examples/vagrant/provision-dev-cluster.sh 2ce74f8a6dc663b62d254bc9d3a5c06cb412107f

>   src/main/python/apache/aurora/executor/BUILD c1c50dbcdcaa56f8ff970ceac59d5db537e1d048

>   src/main/python/apache/aurora/executor/aurora_executor.py 8985aeb60e2c890113ea7d25039cdab5b7c9a19e

>   src/main/python/apache/aurora/executor/bin/BUILD 93517150db96600c92ea25c0de29ec20736d72f7

>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py bc20dad1e5434a98fb51ab052efa8ced760e74e0

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py aacc19a3bd272b08dee8a77d7a64490d0fcad3fa

>   src/main/python/apache/aurora/executor/common/BUILD 0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7

>   src/main/python/apache/aurora/executor/common/health_checker.py 671f4970d4637b8cb68ec89e5dfe96a2f4cd077b

>   src/main/python/apache/aurora/executor/common/kill_manager.py 6e482cfa7d2e081804fe6992527bae0ac5b65080

>   src/main/python/apache/aurora/executor/common/status_checker.py eda30e38d34adc5c78b828d0aea31f0721bf9b20

>   src/main/python/apache/aurora/executor/executor_base.py c632b77d972f76f3e260bb7413aa6100cda46607

>   src/main/python/apache/aurora/executor/gc_executor.py c45d5eb9a99e310e0716abd626ca34615f63b0ae

>   src/main/python/apache/aurora/executor/thermos_task_runner.py 03a40e63573322f2d40e59a8ce84e9b9a1b90aa6

>   src/test/python/apache/aurora/executor/BUILD 3152ec0c0e7dfaec5d756542a89243756b27725d

>   src/test/python/apache/aurora/executor/common/BUILD 6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b

>   src/test/python/apache/aurora/executor/common/test_executor_timeout.py PRE-CREATION

>   src/test/python/apache/aurora/executor/common/test_health_checker.py baeaba29e7679203d83f6ea81455973baf07f324

>   src/test/python/apache/aurora/executor/common/test_kill_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 6ca4fd469bdc7cd21033ccdea460292463bc1cf8

>   src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 0b2278a94667ca4d43e8a84649ed5312acacf7bb

>   src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 55747a19478572e39d1f00f799727d3c3db174c9

>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f7af70fda8fef91018ff9d10dc1db6d43fd16ac7

> 
> Diff: https://reviews.apache.org/r/25208/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew test
> 
> [tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ ./build-support/python/checkstyle-check
&& ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer                         .....
  SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox                 .....
  SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker                    .....
  SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker                    .....
  SUCCESS
> src.test.python.apache.aurora.executor.common.task_info                         .....
  SUCCESS
> src.test.python.apache.aurora.executor.executor_base                            .....
  SUCCESS
> src.test.python.apache.aurora.executor.executor_detector                        .....
  SUCCESS
> src.test.python.apache.aurora.executor.executor_vars                            .....
  SUCCESS
> src.test.python.apache.aurora.executor.gc_executor                              .....
  SUCCESS
> src.test.python.apache.aurora.executor.status_manager                           .....
  SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor                         .....
  SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner                      .....
  SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message