Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95228117D8 for ; Thu, 28 Aug 2014 01:34:27 +0000 (UTC) Received: (qmail 3406 invoked by uid 500); 28 Aug 2014 01:34:27 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 3363 invoked by uid 500); 28 Aug 2014 01:34:27 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 3352 invoked by uid 99); 28 Aug 2014 01:34:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 01:34:27 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 28 Aug 2014 01:34:25 +0000 Received: (qmail 3250 invoked by uid 99); 28 Aug 2014 01:34:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 01:34:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5F3481DD1CB; Thu, 28 Aug 2014 01:34:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9194495712897130929==" MIME-Version: 1.0 Subject: Re: Review Request 25133: Fixing race in task secondary index. From: "Maxim Khutornenko" To: "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 28 Aug 2014 01:34:05 -0000 Message-ID: <20140828013405.17464.94118@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25133/ X-Sender: "Maxim Khutornenko" References: <20140828012638.17468.73109@reviews.apache.org> In-Reply-To: <20140828012638.17468.73109@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============9194495712897130929== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 28, 2014, 1:26 a.m., Kevin Sweeney wrote: > > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java, line 435 > > > > > > This looks like it adds a time dependency to our unit tests, which might cause them to be flaky. Consider using a CountDownLatch instead. The CountdownLatch is already used to wait for completion (see above). This is simply to shut down executor cleanly and is the approach used elsewhere. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25133/#review51736 ----------------------------------------------------------- On Aug. 28, 2014, 1:19 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25133/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 1:19 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-667 > https://issues.apache.org/jira/browse/AURORA-667 > > > Repository: aurora > > > Description > ------- > > Synchronizing around index value retrieval. > > Unit test is mostly verifying general functionality under multhithreaded access. I was not able to repro this locally as doing so reliably would require refactoring that would not make sense otherwise. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f2656de4d723c35a2d3fbe75d9aeb99a353423a2 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 6882c25399fb8c2e499f440ba205e5b0ba71d27a > > Diff: https://reviews.apache.org/r/25133/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============9194495712897130929==--