Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E16111A4A for ; Fri, 22 Aug 2014 23:27:44 +0000 (UTC) Received: (qmail 7862 invoked by uid 500); 22 Aug 2014 23:27:44 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 7821 invoked by uid 500); 22 Aug 2014 23:27:44 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 7810 invoked by uid 99); 22 Aug 2014 23:27:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2014 23:27:43 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 22 Aug 2014 23:27:21 +0000 Received: (qmail 6752 invoked by uid 99); 22 Aug 2014 23:27:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2014 23:27:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E8B1D1DBF29; Fri, 22 Aug 2014 23:27:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0329707000639176273==" MIME-Version: 1.0 Subject: Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain. From: "Joe Smith" To: "Joe Smith" , "Mark Chu-Carroll" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 22 Aug 2014 23:27:18 -0000 Message-ID: <20140822232718.15059.2261@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joe Smith" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/24871/ X-Sender: "Joe Smith" References: <20140822212621.24843.17073@reviews.apache.org> In-Reply-To: <20140822212621.24843.17073@reviews.apache.org> Reply-To: "Joe Smith" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0329707000639176273== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51331 ----------------------------------------------------------- Ship it! Thank you!! - Joe Smith On Aug. 22, 2014, 2:26 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24871/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 2:26 p.m.) > > > Review request for Aurora, Joe Smith and Mark Chu-Carroll. > > > Bugs: AURORA-43 > https://issues.apache.org/jira/browse/AURORA-43 > > > Repository: aurora > > > Description > ------- > > Converting perform_maintenance_hosts into host_drain. > > Also, renaming maintenance commands to address AURORA-43. > > > Diffs > ----- > > src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab > src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 > src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a > src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc > src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a > > Diff: https://reviews.apache.org/r/24871/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > > --===============0329707000639176273==--