Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECAAD11FA3 for ; Mon, 18 Aug 2014 20:11:12 +0000 (UTC) Received: (qmail 50866 invoked by uid 500); 18 Aug 2014 20:11:12 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 50825 invoked by uid 500); 18 Aug 2014 20:11:12 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 50814 invoked by uid 99); 18 Aug 2014 20:11:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Aug 2014 20:11:12 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 18 Aug 2014 20:11:10 +0000 Received: (qmail 50592 invoked by uid 99); 18 Aug 2014 20:10:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Aug 2014 20:10:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B15BA1D430A; Mon, 18 Aug 2014 20:10:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8945315837563840539==" MIME-Version: 1.0 Subject: Re: Review Request 24744: Dropping lock from startJobUpdate parameters. From: "Maxim Khutornenko" To: "Bill Farner" , "Mark Chu-Carroll" Cc: "Aurora" , "Maxim Khutornenko" Date: Mon, 18 Aug 2014 20:10:49 -0000 Message-ID: <20140818201049.7609.93519@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/24744/ X-Sender: "Maxim Khutornenko" References: <20140815235721.5175.2685@reviews.apache.org> In-Reply-To: <20140815235721.5175.2685@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8945315837563840539== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/ ----------------------------------------------------------- (Updated Aug. 18, 2014, 8:10 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Changes ------- Rebasing. Repository: aurora Description ------- The job lock is now acquired by the startJobUpdate call. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ef28858ad290c74248b89c49d2a684eb1c7127e src/main/python/apache/aurora/client/api/__init__.py 62de93bb942adab47590112b76c365fac7877371 src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 649afa24b2cfc9a1d67d350473e439d209bd720c src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 38bc9ed1ea17cac00920a2f1d066458badd7b4bb src/test/python/apache/aurora/client/api/test_api.py 96db25d9f7492a0d49e98af27f17b6cee19f5a49 src/test/python/apache/aurora/client/api/test_scheduler_client.py ab74db34d61e72c50d4ac9252b02cbf69377d194 src/test/resources/org/apache/aurora/gen/api.thrift.md5 0be4d96782769a2097ce10f8872c4300e9f74e5a Diff: https://reviews.apache.org/r/24744/diff/ Testing ------- gradle -Pq build ./pants src/test/python/apache/aurora/client/api:: Thanks, Maxim Khutornenko --===============8945315837563840539==--