Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B8DC111476 for ; Mon, 11 Aug 2014 20:20:08 +0000 (UTC) Received: (qmail 82173 invoked by uid 500); 11 Aug 2014 20:20:08 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 82134 invoked by uid 500); 11 Aug 2014 20:20:08 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 82123 invoked by uid 99); 11 Aug 2014 20:20:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Aug 2014 20:20:07 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 11 Aug 2014 20:19:45 +0000 Received: (qmail 79636 invoked by uid 99); 11 Aug 2014 20:19:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Aug 2014 20:19:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3CCBA1DB6E2; Mon, 11 Aug 2014 20:19:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0866353074879792996==" MIME-Version: 1.0 Subject: Re: Review Request 24465: Add a one-way job update controller. From: "Bill Farner" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Mon, 11 Aug 2014 20:19:25 -0000 Message-ID: <20140811201925.10842.17576@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/24465/ X-Sender: "Bill Farner" References: <20140807231102.11985.48116@reviews.apache.org> In-Reply-To: <20140807231102.11985.48116@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0866353074879792996== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24465/ ----------------------------------------------------------- (Updated Aug. 11, 2014, 8:19 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-613 https://issues.apache.org/jira/browse/AURORA-613 Repository: aurora Description ------- There are 3 levels to performing an update: 1. Move the job from state A to state B, roll back on failure 2. Take a job from state A to state B 3. Take an instance from state A to state B This implements level 2. I made the OneWayJobUpdater generic, which actually simplified both implementation and testing, since it is only responsible for relaying that state down to level 3. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/updater/InstanceStateProvider.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 7476d82e9691449fa968c5fc4c5af76837a5c9cf src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java dda1b73ead847e5ee9c5c7bc8be3cd8a7f59ac80 src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java PRE-CREATION Diff: https://reviews.apache.org/r/24465/diff/ Testing ------- ./gradlew build -Pq OneWayJobUpdater has 100% instruction and branch coverage. Thanks, Bill Farner --===============0866353074879792996==--