Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============1705815670069716164=="
MIME-Version: 1.0
Subject: Re: Review Request 24359: Fix announcer and scheduler_client tests.
From: "Brian Wickman" <wickman@apache.org>
To: "Bill Farner" <wfarner@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Brian Wickman" <wickman@apache.org>
Date: Wed, 06 Aug 2014 16:11:41 -0000
Message-ID: <20140806161141.1586.11783@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Brian Wickman" <noreply@reviews.apache.org>
References: <20140806011402.1587.78248@reviews.apache.org>
In-Reply-To: <20140806011402.1587.78248@reviews.apache.org>
Reply-To: "Brian Wickman" <wickman@apache.org>

--===============1705815670069716164==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24359/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 4:11 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Posting master merge before submitting.


Bugs: AURORA-638
    https://issues.apache.org/jira/browse/AURORA-638


Repository: aurora


Description
-------

Fix tests.


Diffs (updated)
-----

  src/test/python/apache/aurora/executor/common/test_announcer.py e5c4ce4cd0edf0666c5546b734b39121ce93a45c 

Diff: https://reviews.apache.org/r/24359/diff/


Testing
-------

Currently running ./pants src/test/python:all -v

The announcer test does not fail on my laptop.  But I predict what was happening is that since I was just doing 2 clock.tick(1.0)s with the ThreadedClock and the other end was doing a clock.sleep(2.0), there were no guarantees that code was getting executed unless I did a subsequent clock.tick(epsilon).  I've instead just done clock.tick(> 2) to guarantee that code executes.


Thanks,

Brian Wickman


--===============1705815670069716164==--