aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 24662: Implementing job update "get" thrift APIs.
Date Tue, 19 Aug 2014 18:55:17 GMT


> On Aug. 19, 2014, 6:37 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1284
> > <https://reviews.apache.org/r/24662/diff/3/?file=660762#file660762line1284>
> >
> >     Push the requireNonNull out to the first line to avoid even opening the transaction
when the input is bad.

Done.


> On Aug. 19, 2014, 6:37 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1296
> > <https://reviews.apache.org/r/24662/diff/3/?file=660762#file660762line1296>
> >
> >     ditto

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24662/#review51008
-----------------------------------------------------------


On Aug. 14, 2014, 8:20 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24662/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 8:20 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implementing job update "get" thrift APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java ebcb9103d75909080f5b6a69db3a1bf46cfd9780

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5

>   src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 4bad83963b98002f42b470d03e58f832bd96d568

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d34bd6f5fedddb8d70996dc0806b4158f4136874 
> 
> Diff: https://reviews.apache.org/r/24662/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message