aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.
Date Tue, 19 Aug 2014 17:35:33 GMT


> On Aug. 19, 2014, 3:58 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line
74
> > <https://reviews.apache.org/r/24827/diff/1/?file=663946#file663946line74>
> >
> >     A TODO to follow up on "deleted" flag removal?

Removed now, thanks for the nudge.


> On Aug. 19, 2014, 3:58 p.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, lines 545-546
> > <https://reviews.apache.org/r/24827/diff/1/?file=663949#file663949line545>
> >
> >     Is there really anything to resume for the paused updates?

Good point  I'm going to back out the api.thrift change for now as well.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24827/#review50976
-----------------------------------------------------------


On Aug. 19, 2014, 12:09 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24827/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 12:09 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-613
>     https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> asdf
> 
> 
> Add a layer that forwards pubsub events to the JobUpdateController.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 066238cfe51557123d1e055e47bd52aeed9d5579

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 3bbd6dda3e6823e1851efa3d45ea7fa5000d0f39

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java PRE-CREATION

>   src/main/thrift/org/apache/aurora/gen/api.thrift a78a4d849e545000725a39fae49f406422c39da0

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24827/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message