aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 24744: Dropping lock from startJobUpdate parameters.
Date Mon, 18 Aug 2014 20:49:52 GMT


> On Aug. 18, 2014, 8:16 p.m., Mark Chu-Carroll wrote:
> > Looks fine, but I don't really understand the reasoning.
> > 
> > To me, it seems like expecting someone to have a lockid for a pause or a resume
call is a good idea. It allows someone to pass responsibility for an ongoing update to another
person, without having to allow anyone at all to interrupt/resume it.

With the async updater sharing a lock among users or even accross same user sessions becomes
a problem. It should be easier to allow update mutations to any authorized user, which is
true even today (e.g. cancel_update).


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24744/#review50930
-----------------------------------------------------------


On Aug. 18, 2014, 8:10 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24744/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 8:10 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The job lock is now acquired by the startJobUpdate call.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ef28858ad290c74248b89c49d2a684eb1c7127e

>   src/main/python/apache/aurora/client/api/__init__.py 62de93bb942adab47590112b76c365fac7877371

>   src/main/thrift/org/apache/aurora/gen/api.thrift 2b376d663b3bc9264965db58ef89de59b10169ad

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
649afa24b2cfc9a1d67d350473e439d209bd720c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 38bc9ed1ea17cac00920a2f1d066458badd7b4bb

>   src/test/python/apache/aurora/client/api/test_api.py 96db25d9f7492a0d49e98af27f17b6cee19f5a49

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py ab74db34d61e72c50d4ac9252b02cbf69377d194

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 0be4d96782769a2097ce10f8872c4300e9f74e5a

> 
> Diff: https://reviews.apache.org/r/24744/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> ./pants src/test/python/apache/aurora/client/api::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message