aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 24720: Expand actions in JobUpdateAction
Date Mon, 18 Aug 2014 17:59:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/
-----------------------------------------------------------

(Updated Aug. 18, 2014, 5:59 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

rebase. (also, a reminder that I need someone to commit this for me.)


Repository: aurora


Description
-------

Added some more items to the JobUpdateAction enum. Not married to the labels I've chosen,
and I wasn't sure if we want to break out INSTANCE_UPDATING into finer-grained actions. 


Expected actions:

1) instance update: INSTANCE_UPDATED
2) instance remove: INSTANCE_REMOVED
3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
4) noop: INSTANCE_SKIPPED
5) instance rolled back: INSTANCE_ROLLED_BACK


Diffs (updated)
-----

  src/main/thrift/org/apache/aurora/gen/api.thrift af9f02ed1de487bc5cc2967d2edcece5b21e0be5

  src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java f669dbe472ea2171b0ac898b71626f0b25c0a9ec

  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 78798f29bfbcf04b48953d050e498b3cad2248fb

  src/test/resources/org/apache/aurora/gen/api.thrift.md5 21a05f6939da1dd7fc15cf6336bc3fee283f16ab

  src/test/resources/org/apache/aurora/gen/storage.thrift.md5 45762990d33969bedde7340887cde16a535e99fe


Diff: https://reviews.apache.org/r/24720/diff/


Testing
-------

./gradlew -Pq build


Thanks,

David McLaughlin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message