aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jeffryes" <mjeffr...@twitter.com>
Subject Review Request 24752: combine finalization_wait when combining tasks
Date Fri, 15 Aug 2014 23:26:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24752/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Brian Wickman.


Repository: aurora


Description
-------

Problem: combine_task and concat_task helpers lose the finalization_wait information from
all but the first task
Resolution: use sum/max of finialization_wait values in concat_task/combine_task


Diffs
-----

  src/main/python/apache/thermos/config/schema_helpers.py 3feef02d110c154eb92533ccd597a6d517d074a2

  src/test/python/apache/thermos/config/test_schema.py 85b04c0e4d9c29dd85b576b0c296f613879b31a7


Diff: https://reviews.apache.org/r/24752/diff/


Testing
-------

./pants src/test/python:all -vxs


Thanks,

Matthew Jeffryes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message