aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24702: Implementing client job lock and start update APIs.
Date Thu, 14 Aug 2014 17:24:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24702/#review50599
-----------------------------------------------------------



src/main/python/apache/aurora/client/api/updater_util.py
<https://reviews.apache.org/r/24702/#comment88469>

    The doc here might also help explain the behavior.  This wording would be more obvious:
"Groups instance IDs into a set of contiguous integer ranges."


- Bill Farner


On Aug. 14, 2014, 4:08 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24702/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 4:08 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
> 
> 
> Bugs: AURORA-615
>     https://issues.apache.org/jira/browse/AURORA-615
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implementing client job lock and start update APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 371137e469fd65935f4048eaafdcf9b702e8c947

>   src/main/python/apache/aurora/client/api/updater_util.py cbb93e4d64a334dba9d091b68cf6d3594930fa31

>   src/test/python/apache/aurora/client/api/BUILD db5c22375378566f58ade5d6a0b7fcce75ad8394

>   src/test/python/apache/aurora/client/api/test_api.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24702/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/api:api
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message