aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24662: Implementing job update "get" thrift APIs.
Date Thu, 14 Aug 2014 17:17:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24662/#review50597
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/24662/#comment88466>

    Would an error response make more sense in this case?  Drawing a parallel to HTTP, this
would probably be a 404.


- Bill Farner


On Aug. 13, 2014, 7:05 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24662/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 7:05 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implementing job update "get" thrift APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java ebcb9103d75909080f5b6a69db3a1bf46cfd9780

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5

>   src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 4bad83963b98002f42b470d03e58f832bd96d568

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d34bd6f5fedddb8d70996dc0806b4158f4136874 
> 
> Diff: https://reviews.apache.org/r/24662/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message