aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24431: Implementing SQL mappers for saveUpdate and fetchDetails.
Date Thu, 07 Aug 2014 23:58:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24431/#review49971
-----------------------------------------------------------

Ship it!


LGTM once tests cover more than just the happy cases.


src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java
<https://reviews.apache.org/r/24431/#comment87430>

    nit: use the same order for fields, constructor args, and assignments


- Bill Farner


On Aug. 7, 2014, 11:05 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24431/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 11:05 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-612
>     https://issues.apache.org/jira/browse/AURORA-612
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding SQL support for saving updates and fetching update details. 
> 
> The configuration and updateOnlyTheseInstances option support will come separately. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 869590ed3c43c64936af42e60d82f5a6938475d3

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 5d4da0abfd73e5ecbfb99ad81f51fca151124559

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 5d6521813e40eed5cf7e6e0285a7400624c4c5b2

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 8a573f7b04ecc37a19e3886f334f626af577839a

>   src/main/java/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java 844714c08cdaf280c8862e933a95ab009bd9e464

>   src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateMapper.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 618d5b72fd3078ef59571b5f2e33ecce3eb7386c

>   src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateActionTypeHandler.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateStatusTypeHandler.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
f014123348e2b229b2bb9be0dce424327ec0dfbe 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5d3ec36d9907be543296847134c53e6ddc6edc70

>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.xml
PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 3997f9833a7289a49e4f4972efc3f953674bd41b

>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.xml
PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateMapper.xml PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql eb2216ae22ae95370d0b5cd15dbb3d61fca79272

>   src/main/thrift/org/apache/aurora/gen/api.thrift 35d14d48f0c1ea5a4b67380e4c12b99245640a5d

>   src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java a9545e1656a3b1b0ae55155eec4f06878158d8da

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 48600b59b918434ef963b758279c48584ccd34ef

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 f01e4b33ee94ee7e8a36aa71688b699a87bc0566

> 
> Diff: https://reviews.apache.org/r/24431/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message