aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 24465: Add a one-way job update controller.
Date Thu, 07 Aug 2014 23:24:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24465/#review49969
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java
<https://reviews.apache.org/r/24465/#comment87428>

    It's unclear to me why <T> is needed here. Also, this description seems too abstract
(to the point where I'm not sure what is being described here).



src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java
<https://reviews.apache.org/r/24465/#comment87429>

    Not clear why <T> is needed here. Also, the description seems too abstract, maybe
add an example of what this might be used for?


- Kevin Sweeney


On Aug. 7, 2014, 4:11 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24465/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 4:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-613
>     https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> There are 3 levels to performing an update:
> 
> 1. Move the job from state A to state B, roll back on failure
> 2. Take a job from state A to state B
> 3. Take an instance from state A to state B
> 
> This implements level 2.  I made the OneWayJobUpdater generic, which actually simplified
both implementation and testing, since it is only responsible for relaying that state down
to level 3.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceStateProvider.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 7476d82e9691449fa968c5fc4c5af76837a5c9cf

>   src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java dda1b73ead847e5ee9c5c7bc8be3cd8a7f59ac80

>   src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/24465/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> OneWayJobUpdater has 100% instruction and branch coverage.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message