aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <>
Subject Re: Review Request 24465: Add a one-way job update controller.
Date Thu, 07 Aug 2014 23:11:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 7, 2014, 11:11 p.m.)

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Small interface tweaks - made the key identifier type generic, collapsed the two evaluate
functions into one.

Bugs: AURORA-613

Repository: aurora


There are 3 levels to performing an update:

1. Move the job from state A to state B, roll back on failure
2. Take a job from state A to state B
3. Take an instance from state A to state B

This implements level 2.  I made the OneWayJobUpdater generic, which actually simplified both
implementation and testing, since it is only responsible for relaying that state down to level

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/updater/ PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/updater/ 7476d82e9691449fa968c5fc4c5af76837a5c9cf

  src/main/java/org/apache/aurora/scheduler/updater/ PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/updater/ PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/updater/ dda1b73ead847e5ee9c5c7bc8be3cd8a7f59ac80

  src/test/java/org/apache/aurora/scheduler/updater/ PRE-CREATION



./gradlew build -Pq

OneWayJobUpdater has 100% instruction and branch coverage.


Bill Farner

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message