aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <>
Subject Re: Review Request 24357: Refactor InstanceUpdater to remove the callback interface.
Date Wed, 06 Aug 2014 17:52:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 6, 2014, 5:52 p.m.)

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Now ready for a look.  This should make the diff easier to deal with as well.

Repository: aurora


When implementing the layer above InstanceUpdater, i found that the design required a circular
parent/child dependency, among other awkwardness.  The redesign should be much easier to work
with, and IMO is easier to test.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/updater/ 28635177ecd77626c5cb87b02dec225c26eea104

  src/main/java/org/apache/aurora/scheduler/updater/ b725a311647c1fa7d4344b359759d9f20e023533

  src/test/java/org/apache/aurora/scheduler/updater/ a84536369be2ec7620bfa586fa85580773022d30

  src/test/java/org/apache/aurora/scheduler/updater/ PRE-CREATION 



./gradlew build -Pq


Bill Farner

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message