aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation
Date Mon, 04 Aug 2014 23:09:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review49527
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Aug. 4, 2014, 4:02 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 4:02 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-587
>     https://issues.apache.org/jira/browse/AURORA-587
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common.
 Open to suggestions about wiring up -- right now it is enabled via command line flags, but
we don't have prior art for invoking the executor with command line flags (I think the scheduler
just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin
shell wrapper around the executor.pex.)  We can alternately switch to entry_points style a
la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin,
but would require a separate review.  Open to ideas.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 34f2359342958a34532ba9b98b14488efdd07d93 
>   docs/user-guide.md 6c703a3169491c100540b34761ee57a6caa9edcd 
>   examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805 
>   examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb

>   src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e

>   src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c

>   src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b

>   src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b

>   src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8

>   src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c

>   src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23863/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message