aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24243: DB schema for the job update store.
Date Mon, 04 Aug 2014 21:41:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24243/#review49510
-----------------------------------------------------------

Ship it!



src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
<https://reviews.apache.org/r/24243/#comment86588>

    Strongly consider dropping update_id to let the IDENTITY stand alone.



src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
<https://reviews.apache.org/r/24243/#comment86587>

    Feel free to pull the comment up to the top, to signify that we want to change all to
TIMESTAMP.



src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
<https://reviews.apache.org/r/24243/#comment86593>

    Feel free to punt in this review, but BLOB might be preferable here.



src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/24243/#comment86585>

    s/True/true/, which is the keyword thrift uses.



src/test/python/apache/aurora/client/api/test_scheduler_client.py
<https://reviews.apache.org/r/24243/#comment86586>

    doh, thanks


- Bill Farner


On Aug. 4, 2014, 9:04 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24243/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 9:04 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-612
>     https://issues.apache.org/jira/browse/AURORA-612
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> DB tables for the job update store. Sending out early to solicit feedback before moving
to mappers.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 5358b45102f53eea97a1ca709ba9375daa91a3ef

>   src/main/thrift/org/apache/aurora/gen/api.thrift 595c8dfc3d28c2bfa92ae2226a28a8519d75b8c4

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b

> 
> Diff: https://reviews.apache.org/r/24243/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message