aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24206: Add an UpdateStrategy abstraction, with two implementations.
Date Mon, 04 Aug 2014 20:04:33 GMT


> On Aug. 4, 2014, 5:34 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/strategy/ActiveLimitedStrategy.java,
line 36
> > <https://reviews.apache.org/r/24206/diff/1/?file=649183#file649183line36>
> >
> >     protected?

Done.


> On Aug. 4, 2014, 5:34 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/strategy/QueueStrategy.java, line
18
> > <https://reviews.apache.org/r/24206/diff/1/?file=649185#file649185line18>
> >
> >     missing javadoc

Fixed.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24206/#review49466
-----------------------------------------------------------


On Aug. 2, 2014, 5:20 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24206/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 5:20 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-613
>     https://issues.apache.org/jira/browse/AURORA-613
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The JobUpdater will call on an UpdateStrategy to determine how a job update progresses
through instances.  This will remain a code island until the surrounding features are filled
in.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/strategy/ActiveLimitedStrategy.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategy.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/updater/strategy/QueueStrategy.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/updater/strategy/UpdateStrategy.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategyTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/updater/strategy/QueueStrategyTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/24206/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message